Implemented input of preview email address #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now custom addresses can be used to send the test emails Signed-off-by: Alexander Schreiner <github@alexander-schreiner.de>
richardolsson
requested changes
Jan 19, 2025
There was a problem hiding this comment.
I love this! It's a very major improvement in a quick and simple way.
I did find one thing that I would like to request be changed, because it happened to me while playing around that the cached user state reset, and that cascaded and caused this state to also reset. I have suggested the solution below.
src/features/emails/components/EmailEditor/EmailSettings/PreviewTab.tsx
Outdated
Show resolved
Hide resolved
xela1601
force-pushed
the
feature/issue-2441-send-preview-email-to-custom-address
branch
from
99a4c86 to
d4f7d95
Compare
Set email to `user.email` only if it was not touched by the user first Signed-off-by: Alexander Schreiner <github@alexander-schreiner.de>
xela1601
force-pushed
the
feature/issue-2441-send-preview-email-to-custom-address
branch
from
d4f7d95 to
00e61a8
Compare
richardolsson
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Nice! I think this is ready to merge now. It's a major improvement that I know several users who will love. 💯
I have tried the preview build again, and had another look at the code. It all looks great! I appreciate the creativity with regards to validation and UI. 🙌
richardolsson
deleted the
feature/issue-2441-send-preview-email-to-custom-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature, that allows custom addresses to be used to send the test emails.
Screenshots
In case of an invalid email address is entered and the button is being clicked:
Changes
Notes to reviewer
Check out the networks tab in the dev tools to ensure the input email is indeed being sent to the backend (where the email is being sent)
Related issues
Resolves #2441